Skip settle if transaction has already been captured and settled #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkhan-bread
requested review from
chris-asmar,
dschoder-bread and
jdunn-bread
as code owners
dschoder-bread
previously approved these changes
Dec 6, 2024
|
|
||
| $transactionAdditionalInfo = $payment->getTransactionAdditionalInfo(); | ||
|
|
||
| $settleResult = isset($transactionAdditionalInfo['settle_result']) |
There was a problem hiding this comment.
Shopify checks this value for all transaction updates. Settle/Refund/Void/Capture/Authorize. If the transaction is already in that state, we log and don't do anything. Might make sense to do that for the others as well.
Contributor
Author
There was a problem hiding this comment.
@dschoder-bread good call. I'll update it
dschoder-bread
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.